Crash in browsers on certain page

[alex_sh]

Hello,
I get crashes when rendering the following page with Firefox and Opera (with GTK) (but not Konqueror or Chrome) :
http://sourceforge.net/p/gsmartcontrol/code/1/tree/

Debugging shows the crash happens at ftsmooth.c:3118

Code: Select all

      if ( !autohinted  && use_known_settings_on_selected_fonts && mode == FT_RENDER_MODE_LCD
        && ( strcasestr(slot->face->family_name, "Courier New" )
          && ( strcasestr(slot->face->style_name, "Regular" )
            || strcasestr(slot->face->style_name, "Italic" ) ) ) )


family_name is 0x0, style_name is "\177". slot->face seems to have a valid address.
If you can't reproduce it, I'll be happy to help.

I'm using OpenSUSE packages (x86_64), autohinting disabled, hintmedium (gives better shapes to e.g. 'e' than hintslight), no local.conf, untouched infinality-settings.sh.

[infinality]

Thank you for the report. Yes, this is a known issue that will be fixed in the next release.

[alex_sh]

Thanks for the reply.
Is there a small fix that can be applied to fix this crash? Apart from being a security issue, it's also quite annoying
Or, failing that, what's the estimated date for the next release?

[infinality]

Thanks for the reply.
Is there a small fix that can be applied to fix this crash? Apart from being a security issue, it's also quite annoying
Or, failing that, what's the estimated date for the next release?

Yes, it's relatively a simple fix:

Add this line:

Code: Select all

        && slot->face->family_name && slot->face->style_name

Just prior to this:

Code: Select all

        && ( strcasestr(slot->face->family_name, "Courier New" )

Also, you'd want to do something similar in the parts just below it that reference slot->face->family_name or slot->face->style_name. Sorry I don't have a real patch at the moment.

[notlostyet]

Arch AUR users can get an updated tarball with a patch and PKGBUILD that fixes this issue here:

http://oron.com/vrwi73ugk153

[infinality]

what's the estimated date for the next release?

I'm hoping to have a release within a week or two. It will mainly be cleanup, fixes, and minor tweaks.

[alex_sh]

Thanks, I applied the AUR patch and the problem seems to be gone.

Your work is invaluable for the Linux desktop, infinality. Thanks a lot for doing all this!