Welcome! Anonymous

Crash in browsers on certain page

A place to ask questions, or discuss anything related to infinality.net stuff.

Crash in browsers on certain page

Postby alex_sh » Wed Dec 14, 2011 4:59 am

Hello,
I get crashes when rendering the following page with Firefox and Opera (with GTK) (but not Konqueror or Chrome) :
http://sourceforge.net/p/gsmartcontrol/code/1/tree/

Debugging shows the crash happens at ftsmooth.c:3118

Code: Select all
      if ( !autohinted  && use_known_settings_on_selected_fonts && mode == FT_RENDER_MODE_LCD
        && ( strcasestr(slot->face->family_name, "Courier New" )
          && ( strcasestr(slot->face->style_name, "Regular" )
            || strcasestr(slot->face->style_name, "Italic" ) ) ) )


family_name is 0x0, style_name is "\177". slot->face seems to have a valid address.
If you can't reproduce it, I'll be happy to help.

I'm using OpenSUSE packages (x86_64), autohinting disabled, hintmedium (gives better shapes to e.g. 'e' than hintslight), no local.conf, untouched infinality-settings.sh.
alex_sh
 
Posts: 12
Joined: Tue Dec 13, 2011 3:05 pm

Re: Crash in browsers on certain page

Postby infinality » Wed Dec 14, 2011 7:47 am

Thank you for the report. Yes, this is a known issue that will be fixed in the next release.
- Linux font rendering has gone from the most reviled to the most renowned.
User avatar
infinality
Site Admin
 
Posts: 733
Joined: Wed Oct 20, 2010 7:57 am
Location: Wisconsin, USA

Re: Crash in browsers on certain page

Postby alex_sh » Wed Dec 14, 2011 8:15 am

Thanks for the reply.
Is there a small fix that can be applied to fix this crash? Apart from being a security issue, it's also quite annoying :)
Or, failing that, what's the estimated date for the next release?
alex_sh
 
Posts: 12
Joined: Tue Dec 13, 2011 3:05 pm

Re: Crash in browsers on certain page

Postby infinality » Wed Dec 14, 2011 9:20 am

alex_sh wrote:Thanks for the reply.
Is there a small fix that can be applied to fix this crash? Apart from being a security issue, it's also quite annoying :)
Or, failing that, what's the estimated date for the next release?


Yes, it's relatively a simple fix:

Add this line:
Code: Select all
        && slot->face->family_name && slot->face->style_name

Just prior to this:
Code: Select all
        && ( strcasestr(slot->face->family_name, "Courier New" )


Also, you'd want to do something similar in the parts just below it that reference slot->face->family_name or slot->face->style_name. Sorry I don't have a real patch at the moment.

:ugeek:
- Linux font rendering has gone from the most reviled to the most renowned.
User avatar
infinality
Site Admin
 
Posts: 733
Joined: Wed Oct 20, 2010 7:57 am
Location: Wisconsin, USA

Re: Crash in browsers on certain page

Postby notlostyet » Wed Dec 14, 2011 4:00 pm

Arch AUR users can get an updated tarball with a patch and PKGBUILD that fixes this issue here:

http://oron.com/vrwi73ugk153
notlostyet
 
Posts: 1
Joined: Wed Dec 14, 2011 3:59 pm

Re: Crash in browsers on certain page

Postby infinality » Wed Dec 14, 2011 8:14 pm

alex_sh wrote:what's the estimated date for the next release?


I'm hoping to have a release within a week or two. It will mainly be cleanup, fixes, and minor tweaks.
- Linux font rendering has gone from the most reviled to the most renowned.
User avatar
infinality
Site Admin
 
Posts: 733
Joined: Wed Oct 20, 2010 7:57 am
Location: Wisconsin, USA

Re: Crash in browsers on certain page

Postby alex_sh » Thu Dec 15, 2011 12:07 pm

Thanks, I applied the AUR patch and the problem seems to be gone.

Your work is invaluable for the Linux desktop, infinality. Thanks a lot for doing all this!
alex_sh
 
Posts: 12
Joined: Tue Dec 13, 2011 3:05 pm


Return to General Discussion

Who is online

Users browsing this forum: No registered users and 2 guests